Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @redwoodjs/project-model (+ Language Server) #810

Conversation

aldonline
Copy link
Contributor

@@ -32,6 +32,17 @@
"@types/node": "^12.12.0",
"@types/vscode": "^1.46.0"
},
"eslintConfig": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few eslint rule overrides.

  • import/order - this is just for convenience, we can remove it eventually
  • no-this-alias - this is necessary. some patterns (like using generator functions) require the const self=this alias
  • no-non-null-assertion: this is necessary. there is a reason this assertion exists. especially when type-guards cannot be used (or require convoluted rewrites).
  • no-case-declarations: supporting this rule would require rewriting most logic of the interactive_cli. I'm not opposed to doing that, but it doesn't add any value
  • prefer-const: we could activate this rule eventually. there are some parts of the code that use "let" to allow quickly changing values when testing (by adding an extra assignment)
  • no-unused-expressions: This gets in the way when using Wallaby.js

@peterp peterp mentioned this pull request Jul 9, 2020
7 tasks
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterp peterp added this to the next release milestone Jul 9, 2020
@peterp peterp merged commit 9a9651e into redwoodjs:pp-integrate-decoupled Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants