Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold table styles #844

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Conversation

SimeonGriggs
Copy link
Contributor

The default scaffold styles do not apply a text colour to the .rw-main class, so some elements inside inherit their text colour. With mixed results.

If your app is dark-with-white-text, the text is invisible. Demonstrated in the screenshots below.

Applying colour here to .rw-main might be considered too high up, but it fixes this issue.

Screen Shot 2020-07-14 at 2 15 12 pm

Screen Shot 2020-07-14 at 2 15 20 pm

@SimeonGriggs SimeonGriggs marked this pull request as ready for review July 14, 2020 13:21
Copy link
Contributor

@Terris Terris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cannikin cannikin merged commit b471456 into redwoodjs:main Jul 16, 2020
@thedavidprice thedavidprice added this to the next release milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants