prepopulate apollo cache on prerendered pages #8566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
approved these changes
Jun 16, 2023
|
Sweet sweet fix KC! |
jtoar
pushed a commit
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things.
Preloads the Apollo Client Cache on the frontend with the fetched data we retrieved during prerendering. This allows the data served during prerender to match the client data and properly prerender
There was an issue where prendering for cells is 50% working. It works without javascript but with Javascript enabled prerendered pages would fallback to client-side rendering so users would immediately see a loading spinner even though the content of the pages was already available
Fixes a workaround that we had in place to prevent cells from throwing react 18 server / client mismatch errors.
We were using Suspense with a null fallback to prevent React from displaying errors in the console. This hid the error but didn't solve the issue