Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Tweak comments in redwood.toml #8744

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 26, 2023

I always get insecure about the array syntax in the toml for listing env vars. Like, am I allowed to have newlines?
Hopefully adding the comments on new lines inside the array makes it clear that you're allowed to do that.

Ideally I'd like the comment to say:

Add ENV_VARs each on their own line. Quote the variable name and end the line with a comma (,). Like this:
'EXAMPLE_VAR_ONE',
'EXAMPLE_VAR_TWO',

I figured that was too long, but happy to take suggestions on how to further improve the wording in the PR

@Tobbe Tobbe requested a review from ahaywood June 26, 2023 20:30
@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) release:fix This PR is a fix and removed release:chore This PR is a chore (means nothing for users) labels Jun 26, 2023
Copy link
Contributor

@ahaywood ahaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tobbe Tobbe enabled auto-merge (squash) June 26, 2023 20:34
@Tobbe Tobbe merged commit 89d46b8 into redwoodjs:main Jun 26, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 26, 2023
@Tobbe Tobbe deleted the tobbe-redwood-toml-env-array-comment branch June 26, 2023 22:00
jtoar pushed a commit that referenced this pull request Jun 27, 2023
@jtoar jtoar modified the milestones: next-release, v5.4.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants