fix(graphql-server): Improve GraphQL API performance by not accessing project config in makeMergedSchema #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a performance issue
dthyresson
changed the title
dthyresson
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
@Josh-Walker-GM and I paired one this PR and determined by running many k6 benchmark tests that accessing the project config was costly for two reasons: 1) access file system and 2) when deployed in serverless like Netlify or Vercel since there is no file system throwing an error adds to the cost.
We realized that the GraphQL handler already had options to "use open telemetry" and if that was present then the plugin was added -- and that fact could be used to determine to enable and wrap resolvers if needed. Thus no project config access is needed and performance return to v5.4.3 levels.
|
For reference: |
jtoar
pushed a commit
that referenced
this pull request
Aug 11, 2023
… project config in makeMergedSchema (#9032) **Problem** The toml config is not always available in serverless deploy environments and because `makeMergedSchema` is called on every request (in such deploy environments) then throwing & catching a JS error causes a heavy performance decrease. **Changes** 1. Base the opentelemetry functionality on the graphql plugin options alone. **Notes** 1. Will have to update the experimental docs. You must disable both toml and graphql options now as toml does not override/impact the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The toml config is not always available in serverless deploy environments and because
makeMergedSchemais called on every request (in such deploy environments) then throwing & catching a JS error causes a heavy performance decrease.Changes
Notes