Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggested code snippet #9288

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix suggested code snippet #9288

merged 1 commit into from
Oct 10, 2023

Conversation

pepicrft
Copy link
Contributor

While using RedwoodJS I noticed I got suggested a TOML code snippet that's missing some trailing commas. This PR adds them:

Before

   includeEnvironmentVariables = [
     "AUTH0_DOMAIN"
     "AUTH0_CLIENT_ID"
     "AUTH0_REDIRECT_URI"
     "AUTH0_AUDIENCE"
   ]

After

   includeEnvironmentVariables = [
     "AUTH0_DOMAIN",
     "AUTH0_CLIENT_ID",
     "AUTH0_REDIRECT_URI",
     "AUTH0_AUDIENCE"
   ]

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pepicrft!

@jtoar jtoar added the release:fix This PR is a fix label Oct 10, 2023
@jtoar jtoar added this to the next-release-patch milestone Oct 10, 2023
@jtoar jtoar merged commit 1bada1e into redwoodjs:main Oct 10, 2023
33 of 35 checks passed
jtoar pushed a commit that referenced this pull request Oct 10, 2023
While using RedwoodJS I noticed I got suggested a TOML code snippet
that's missing some trailing commas. This PR adds them:

**Before**
```toml title="redwood.toml"
   includeEnvironmentVariables = [
     "AUTH0_DOMAIN"
     "AUTH0_CLIENT_ID"
     "AUTH0_REDIRECT_URI"
     "AUTH0_AUDIENCE"
   ]
```
**After**
```toml title="redwood.toml"
   includeEnvironmentVariables = [
     "AUTH0_DOMAIN",
     "AUTH0_CLIENT_ID",
     "AUTH0_REDIRECT_URI",
     "AUTH0_AUDIENCE"
   ]
```
jtoar pushed a commit that referenced this pull request Nov 3, 2023
While using RedwoodJS I noticed I got suggested a TOML code snippet
that's missing some trailing commas. This PR adds them:

**Before**
```toml title="redwood.toml"
   includeEnvironmentVariables = [
     "AUTH0_DOMAIN"
     "AUTH0_CLIENT_ID"
     "AUTH0_REDIRECT_URI"
     "AUTH0_AUDIENCE"
   ]
```
**After**
```toml title="redwood.toml"
   includeEnvironmentVariables = [
     "AUTH0_DOMAIN",
     "AUTH0_CLIENT_ID",
     "AUTH0_REDIRECT_URI",
     "AUTH0_AUDIENCE"
   ]
```
@jtoar jtoar modified the milestones: next-release-patch, v6.3.3 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants