Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): Remove unused import #9946

Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 31, 2024

We generate .redwood/types/includes/web-routerRoutes.d.ts to provide proper types for routes that users import from @redwoodjs/router.

This file used to be a lot more complicated, but was greatly simplified in #6364. However, we forgot to remove an import that's no longer used. This PR cleans that up

image

@Tobbe Tobbe added the release:fix This PR is a fix label Jan 31, 2024
@Tobbe Tobbe added this to the v7.0.0 milestone Jan 31, 2024
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and adding tests will help prevent any issues with the line offsets we have in the source.

@Tobbe Tobbe merged commit a7b1573 into redwoodjs:main Jan 31, 2024
38 checks passed
@Tobbe Tobbe deleted the tobbe-web-router-routes-d-ts-remove-unused-import branch January 31, 2024 16:47
jtoar pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants