Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: KML coordinates splitting #25

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix: KML coordinates splitting #25

merged 1 commit into from
Jul 16, 2021

Conversation

mimoham24
Copy link
Contributor

Overview

Fix the bug that KML coordinates were not decoded for "\t" separator

What I've done

replaced strings.Split() with strings.Fields() to cover all white spaces

What I haven't done

How I tested

separated coordinates for each white-space

Which point I want you to review particularly

Memo

Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never heard of strings.Fields before. That's a useful function.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #25 (1f0c307) into main (8469574) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   16.00%   16.00%           
=======================================
  Files         198      198           
  Lines       40002    40002           
=======================================
  Hits         6401     6401           
  Misses      32633    32633           
  Partials      968      968           
Impacted Files Coverage Δ
pkg/layer/decoding/kml.go 62.77% <100.00%> (ø)

@mimoham24 mimoham24 merged commit ba7d164 into main Jul 16, 2021
@mimoham24 mimoham24 deleted the fix/KMLcoordsspliting branch July 16, 2021 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants