Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storytelling collapse when the layer is deleted #7

Closed
KaWaite opened this issue Jul 26, 2021 · 0 comments
Closed

Storytelling collapse when the layer is deleted #7

KaWaite opened this issue Jul 26, 2021 · 0 comments
Labels
bug Something isn't working frontend

Comments

@KaWaite
Copy link
Member

KaWaite commented Jul 26, 2021

Describe the bug
When the layer that is registered as the storytelling story is deleted, it remains as the story though it doesn't exist on the digital Earth.

To Reproduce
Steps to reproduce the behavior:

  1. add a couple of layers to the earth
  2. activate storytelling
  3. add them to the storytelling list
  4. delete a layer from the outline window
  5. play with storytelling
  6. storytelling will collapse since there isn't the layer which storytelling expects to have

11/10/2021 KaWaite

  • Seems storytelling's property references the Layers (stories), which on Layer deletion of course doesn't search through all widgets that might reference that Layer and delete references to it. Either do a sweep (probably not a good solution) or create a warning before Layer deletion.
@KaWaite KaWaite added bug Something isn't working frontend labels Jul 26, 2021
KeisukeYamashita pushed a commit that referenced this issue Aug 13, 2022
Co-authored-by: Ya Ka <eng.ymk@gmail.com>
Co-authored-by: HideBa <49897538+HideBa@users.noreply.github.com>
pyshx pushed a commit that referenced this issue Apr 17, 2023
@KaWaite KaWaite closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

3 participants