Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): wrong workspace when sharing link #506

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Jun 15, 2023

Overview

when user shares link and then change the workspace , the system returns last workspace instead of the right workspace that project belongs too.
Also I did some refactoring to purge team from system.
Also fix saving workspace when navigate to dashboard

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit baeecc2
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/649555e4cb38820009236e52
😎 Deploy Preview https://deploy-preview-506--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the web label Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #506 (baeecc2) into main (36ddb20) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   26.65%   26.65%   -0.01%     
==========================================
  Files        1336     1336              
  Lines      144628   144636       +8     
  Branches     3483     3483              
==========================================
  Hits        38555    38555              
- Misses     104951   104959       +8     
  Partials     1122     1122              
Flag Coverage Δ
web 23.98% <0.00%> (-0.01%) ⬇️
web-beta 23.98% <0.00%> (-0.01%) ⬇️
web-classic 23.98% <0.00%> (-0.01%) ⬇️
web-utils 23.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/features/Navbar/hooks.ts 0.00% <0.00%> (ø)
.../components/molecules/EarthEditor/Header/index.tsx 0.00% <0.00%> (ø)
...rc/classic/components/organisms/Dashboard/hooks.ts 0.00% <0.00%> (ø)
...c/components/organisms/EarthEditor/Header/hooks.ts 0.00% <0.00%> (ø)
.../components/organisms/EarthEditor/Header/index.tsx 0.00% <0.00%> (ø)

@nina992 nina992 marked this pull request as ready for review June 15, 2023 19:12
@github-actions github-actions bot requested a review from pyshx June 15, 2023 19:13
@nina992 nina992 changed the title fix: wrong workspace when sharing link fix(web): wrong workspace when sharing link Jun 16, 2023
nina992 and others added 4 commits June 22, 2023 10:00
@nina992 nina992 merged commit 5b939eb into main Jun 23, 2023
@nina992 nina992 deleted the fix/wrong-workspace-when-sharing-link branch June 23, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants