Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add line-height option to story text block #703

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

airslice
Copy link
Contributor

Overview

This PR adds line-height option (1.0-2.0) to story text block.
This PR also fixes a bug which leads to crash sometimes.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 71db694
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/651269a92f6a490008a94115
😎 Deploy Preview https://deploy-preview-703--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 25, 2023
@airslice airslice marked this pull request as ready for review September 25, 2023 07:54
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #703 (2df979e) into main (3e3549b) will decrease coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 19.73%.

❗ Current head 2df979e differs from pull request most recent head 71db694. Consider uploading reports for the commit 71db694 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   28.21%   28.13%   -0.09%     
==========================================
  Files        1569     1568       -1     
  Lines      171521   171168     -353     
  Branches     3818     3820       +2     
==========================================
- Hits        48401    48159     -242     
+ Misses     122031   121920     -111     
  Partials     1089     1089              
Flag Coverage Δ
web 26.78% <19.73%> (-0.11%) ⬇️
web-beta 26.78% <19.73%> (-0.11%) ⬇️
web-classic 26.78% <19.73%> (-0.11%) ⬇️
web-utils 26.78% <19.73%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...b/lexical/RichTextEditor/plugins/ToolbarPlugin.tsx 12.45% <19.73%> (+0.70%) ⬆️

... and 12 files with indirect coverage changes

@airslice airslice merged commit fcf04f2 into main Sep 26, 2023
12 checks passed
@airslice airslice deleted the chore/story-text-block-lineheight branch September 26, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants