Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix layerName random on upload directly #781

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

pyshx
Copy link
Contributor

@pyshx pyshx commented Nov 1, 2023

Overview

This PR is the follow-up of #779 where is covers the layer uploaded direct to also have the filename as the starting layerName and Also adds small styles to leftPanel's layerName.

@pyshx pyshx requested a review from KaWaite as a code owner November 1, 2023 10:27
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 550ed19
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654228364592fa000841d839
😎 Deploy Preview https://deploy-preview-781--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pyshx pyshx changed the title Chore/fix random name w asset chore(web): fix layerName random on upload directly Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #781 (550ed19) into main (16cbcde) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   26.10%   26.10%   -0.01%     
==========================================
  Files        1621     1621              
  Lines      177177   177189      +12     
  Branches     3910     3908       -2     
==========================================
  Hits        46251    46251              
- Misses     129837   129849      +12     
  Partials     1089     1089              
Flag Coverage Δ
web 24.38% <0.00%> (-0.01%) ⬇️
web-beta 24.38% <0.00%> (-0.01%) ⬇️
web-classic 24.38% <0.00%> (-0.01%) ⬇️
web-utils 24.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/hooks/useAssetUploader/hooks.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/LeftPanel/Layers/LayerItem.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@pyshx pyshx merged commit 2d69621 into main Nov 1, 2023
14 of 16 checks passed
@pyshx pyshx deleted the chore/fix-random-name-w-asset branch November 1, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant