Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): modify zoom level in manifest #807

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Nov 13, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from pyshx as a code owner November 13, 2023 15:15
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 352415f
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/655ca3c1cbe75500081e1feb
😎 Deploy Preview https://deploy-preview-807--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #807 (352415f) into main (f9a7d49) will increase coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   25.69%   25.79%   +0.10%     
==========================================
  Files        1637     1633       -4     
  Lines      180150   179169     -981     
  Branches     3912     3897      -15     
==========================================
- Hits        46287    46224      -63     
+ Misses     132774   131856     -918     
  Partials     1089     1089              
Flag Coverage Δ
server 33.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Editor/Visualizer/convert.ts 0.00% <ø> (ø)
...abs/widgets/RightPanel/ContainerSettings/index.tsx 0.00% <ø> (ø)
web/src/beta/features/PublishedVisualizer/hooks.ts 0.00% <ø> (ø)
.../lib/core/Crust/Widgets/WidgetAlignSystem/Area.tsx 0.00% <ø> (ø)
web/src/beta/lib/core/Crust/featureFlags.ts 0.00% <ø> (ø)
web/src/beta/lib/core/Crust/interactionMode.ts 0.00% <ø> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <ø> (ø)
web/src/beta/lib/core/engines/Cesium/hooks.ts 0.00% <ø> (ø)
...ssic/core/Crust/Widgets/WidgetAlignSystem/Area.tsx 0.00% <ø> (ø)
...ver/internal/adapter/gql/gqlmodel/convert_value.go 2.77% <0.00%> (-0.13%) ⬇️

... and 76 files with indirect coverage changes

@nina992 nina992 merged commit ae55944 into main Nov 21, 2023
16 of 17 checks passed
@nina992 nina992 deleted the chore/add-min-max-to-zoomLevel branch November 21, 2023 12:55
mkumbobeaty pushed a commit that referenced this pull request Nov 22, 2023
Co-authored-by: nina992 <nouralali992@gmail.com>
Co-authored-by: pyshx <piyushchauhan1004@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants