Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix camera behavior in interaction mode #824

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Nov 20, 2023

Overview

Fixed camera behavior for each interaction mode.

What I've done

  • Added some feature flags for camera.
  • Use tilt in selection mode.

What I haven't done

How I tested

  1. `reearth.interactionMode.override("selection")
  2. CTRL + Drag should work.
  3. Shift + Drag should not work.
  4. Zoom(scroll) should work.
  5. Drag should not work.

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Nov 20, 2023
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit fb6c58a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/655ab8cdd1af5f00094f22b3
😎 Deploy Preview https://deploy-preview-824--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 20, 2023
@keiya01 keiya01 requested review from airslice and removed request for nina992 November 20, 2023 01:40
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #824 (fb6c58a) into main (f9a7d49) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   25.69%   25.69%   -0.01%     
==========================================
  Files        1637     1637              
  Lines      180150   180166      +16     
  Branches     3912     3913       +1     
==========================================
+ Hits        46287    46288       +1     
- Misses     132774   132789      +15     
  Partials     1089     1089              
Flag Coverage Δ
web 23.91% <0.00%> (-0.01%) ⬇️
web-beta 23.91% <0.00%> (-0.01%) ⬇️
web-classic 23.91% <0.00%> (-0.01%) ⬇️
web-utils 23.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/engines/Cesium/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/featureFlags.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/interactionMode.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@keiya01 keiya01 merged commit 912d681 into main Nov 20, 2023
17 checks passed
@keiya01 keiya01 deleted the fix/interation-mode-move branch November 20, 2023 03:46
mkumbobeaty added a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants