Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): stringify label text #848

Merged
merged 2 commits into from
Dec 1, 2023
Merged

chore(web): stringify label text #848

merged 2 commits into from
Dec 1, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Dec 1, 2023

Overview

When use expression to set label text we get values from feature property and the value could be number.
When pass number to LabelGraphics text, cesium will throw out error.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 42e2247
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65697704852dd90008c3a27d
😎 Deploy Preview https://deploy-preview-848--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@airslice airslice marked this pull request as ready for review December 1, 2023 04:38
@github-actions github-actions bot added the web label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #848 (42e2247) into main (7aa3463) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   25.61%   25.61%           
=======================================
  Files        1644     1644           
  Lines      180743   180745    +2     
  Branches     3919     3920    +1     
=======================================
+ Hits        46298    46301    +3     
+ Misses     133356   133355    -1     
  Partials     1089     1089           
Flag Coverage Δ
web 23.82% <0.00%> (+<0.01%) ⬆️
web-beta 23.82% <0.00%> (+<0.01%) ⬆️
web-classic 23.82% <0.00%> (+<0.01%) ⬆️
web-utils 23.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/lib/core/engines/Cesium/Feature/Marker/index.tsx 13.77% <0.00%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes

@airslice airslice merged commit 17bcc69 into main Dec 1, 2023
16 checks passed
@airslice airslice deleted the chore/string-label-text branch December 1, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants