Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix published WAS area padding #850

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Dec 4, 2023

Overview

This PR fixes the issue that padding value 0 will be ingored in published WAS area.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 86a9c0e
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/656d57500a85bd00086f8d11
😎 Deploy Preview https://deploy-preview-850--reearth-web.netlify.app/published
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Dec 4, 2023
@airslice airslice marked this pull request as ready for review December 4, 2023 03:07
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #850 (86a9c0e) into main (c8ad896) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   25.61%   25.61%           
=======================================
  Files        1644     1644           
  Lines      180739   180739           
  Branches     3920     3920           
=======================================
+ Hits        46297    46301    +4     
+ Misses     133353   133349    -4     
  Partials     1089     1089           
Flag Coverage Δ
web 23.82% <0.00%> (+<0.01%) ⬆️
web-beta 23.82% <0.00%> (+<0.01%) ⬆️
web-classic 23.82% <0.00%> (+<0.01%) ⬆️
web-utils 23.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/PublishedVisualizer/hooks.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@airslice airslice merged commit 569681f into main Dec 4, 2023
16 checks passed
@airslice airslice deleted the chore/published-was-area-padding branch December 4, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants