Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing is included in 3.5+, drop separate requirement #2

Closed
wants to merge 3 commits into from
Closed

typing is included in 3.5+, drop separate requirement #2

wants to merge 3 commits into from

Conversation

scop
Copy link
Contributor

@scop scop commented Aug 1, 2019

No description provided.

@reefab
Copy link
Owner

reefab commented Aug 1, 2019

Thanks for the pull request. It's indeed a good idea to remove this dependency if it's built-in.

Alas, it seems to break the tests: https://travis-ci.org/reefab/foobot_async/builds/566295319

I'll have to dig deeper into this, this should be the same module, just built-in. Not sure why it doesn't work anymore.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.8%) to 97.222%

Changes Missing Coverage Covered Lines Changed/Added Lines %
foobot_async/init.py 2 4 50.0%
Totals Coverage Status
Change from base Build 11: -2.8%
Covered Lines: 70
Relevant Lines: 72

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.8%) to 97.222%

Changes Missing Coverage Covered Lines Changed/Added Lines %
foobot_async/init.py 2 4 50.0%
Totals Coverage Status
Change from base Build 11: -2.8%
Covered Lines: 70
Relevant Lines: 72

💛 - Coveralls

@scop
Copy link
Contributor Author

scop commented Oct 19, 2019

The failure doesn't seem to have anything directly to do with typing; it's just that DEFAULT_TIMEOUT is no longer a float in aiohttp >= 3.3. Anyway this should be fixed by the addon commit(s) here, Travis is green now.

@matlimatli
Copy link

Any progress on this? The now obsolete dependency on typing seems to be causing some trouble with the home-assistant tox setup in some cases.

@reefab
Copy link
Owner

reefab commented May 27, 2020

Sorry for having dropped this PR.

I've uploaded a new release that drops the typing requirement, ups the aiohttp and now officially supports python 3.7 and 3.8.

@reefab reefab closed this May 27, 2020
@scop scop deleted the drop-typing-dep branch May 27, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants