Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise scenario class #20

Merged
merged 30 commits into from
Mar 2, 2021
Merged

Revise scenario class #20

merged 30 commits into from
Mar 2, 2021

Conversation

uvchik
Copy link
Member

@uvchik uvchik commented Mar 1, 2021

The scenario class was quite big due to historical reasons. Furthermore only part of the class was dumped using the dump method.

  1. Use the dump method for the scenario class and not only for the results
  2. Clean the scenario class and remove attributes
  3. Add a simple compute() method.

@uvchik uvchik self-assigned this Mar 1, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 2, 2021

Hello @uvchik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 76:9: W503 line break before binary operator

Line 40:17: W503 line break before binary operator

Comment last updated at 2021-03-02 12:08:36 UTC

@uvchik uvchik merged commit 48449c0 into master Mar 2, 2021
@uvchik uvchik deleted the revision/revise-Scenario-class branch March 2, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants