Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of v3.9.0 fails with --feature=rkyv #137

Closed
blp opened this issue Aug 22, 2023 · 3 comments
Closed

Build of v3.9.0 fails with --feature=rkyv #137

blp opened this issue Aug 22, 2023 · 3 comments

Comments

@blp
Copy link
Contributor

blp commented Aug 22, 2023

v3.9.0 uses the rend feature in rkyv that rkyv only implements conditionally on other features. This breaks the build if you specify the rkyv feature. This is true in v3.9.0 but not in v3.8.0:

[blp@sigxcpu rust-ordered-float]$ git checkout v3.8.0
HEAD is now at 651ead6 Version 3.8.0
[blp@sigxcpu rust-ordered-float]$ cargo build --features=rkyv
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
[blp@sigxcpu rust-ordered-float]$ git checkout v3.9.0
Previous HEAD position was 651ead6 Version 3.8.0
HEAD is now at 2650e6e Version 3.9.0
[blp@sigxcpu rust-ordered-float]$ cargo build --features=rkyv
   Compiling ordered-float v3.9.0 (/home/blp/feldera/rust-ordered-float)
error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2006:45
     |
2006 |     rkyv_eq_ord! { OrderedFloat, f32, rkyv::rend::f32_le }
     |                                             ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2007:45
     |
2007 |     rkyv_eq_ord! { OrderedFloat, f32, rkyv::rend::f32_be }
     |                                             ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2008:45
     |
2008 |     rkyv_eq_ord! { OrderedFloat, f64, rkyv::rend::f64_le }
     |                                             ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2009:45
     |
2009 |     rkyv_eq_ord! { OrderedFloat, f64, rkyv::rend::f64_be }
     |                                             ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2010:39
     |
2010 |     rkyv_eq_ord! { NotNan, f32, rkyv::rend::f32_le }
     |                                       ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2011:39
     |
2011 |     rkyv_eq_ord! { NotNan, f32, rkyv::rend::f32_be }
     |                                       ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2012:39
     |
2012 |     rkyv_eq_ord! { NotNan, f64, rkyv::rend::f64_le }
     |                                       ^^^^ could not find `rend` in `rkyv`

error[E0433]: failed to resolve: could not find `rend` in `rkyv`
    --> src/lib.rs:2013:39
     |
2013 |     rkyv_eq_ord! { NotNan, f64, rkyv::rend::f64_be }
     |                                       ^^^^ could not find `rend` in `rkyv`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `ordered-float` (lib) due to 8 previous errors
[blp@sigxcpu rust-ordered-float]$ 
blp added a commit to feldera/feldera that referenced this issue Aug 22, 2023
ordered-float v3.9.0 is broken:
reem/rust-ordered-float#137

Until it's fixed or yanked, avoid upgrade.

Signed-off-by: Ben Pfaff <blp@feldera.com>
blp added a commit to feldera/feldera that referenced this issue Aug 22, 2023
ordered-float v3.9.0 is broken:
reem/rust-ordered-float#137

Until it's fixed or yanked, avoid upgrade.

Signed-off-by: Ben Pfaff <blp@feldera.com>
@mbrubeck
Copy link
Collaborator

cc #136

@mbrubeck
Copy link
Collaborator

Fixed in ordered-float 3.9.1.

@blp
Copy link
Contributor Author

blp commented Aug 22, 2023

Fixed in ordered-float 3.9.1.

Beautiful! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants