Implement traits from the 'rand' crate. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks! I added a minor change to the tests to make them build on older versions of Rust. |
|
@mbrubeck Hi! This isn't really anyone's fault but this PR has broken a number of projects that use this crate on the I've resolved my personal issue disabling default features on your crate but I wanted you to know what impact this change has had. Thanks for your crate! |
|
Oops! This is fixed by #90 in ordered-float 2.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #83. Implements sampling in the Standard, Open01, and OpenClosed01 distributions. Uniform sampling is also implemented.
This is my first Rust PR and I wouldn't mind feedback.