Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on jQuery & Bootstrap #8

Closed
wulftone opened this issue Apr 25, 2014 · 2 comments
Closed

Depends on jQuery & Bootstrap #8

wulftone opened this issue Apr 25, 2014 · 2 comments

Comments

@wulftone
Copy link

Ran into an issue and traced it back to jQLite not having jQuery's element.is function. Might either want to make it jQuery-free, or add the dependency to bower?

@wulftone
Copy link
Author

Also bootstrap. : )

@wulftone wulftone changed the title Depends on jQuery Depends on jQuery & Bootstrap Apr 25, 2014
@refactorthis
Copy link
Owner

Hi yes this is very true, wouldn't be hard to change it so it doesn't depend on jQuery, especially since angular comes with jqLite. as for bootstrap. I call call a plugin in called tooltip() and it be up to the developer to handle that. It could be handled better. I don't really have time at the moment but if you are willing to put in a PR I'll definitely merge these changes.

refactorthis pushed a commit that referenced this issue Sep 9, 2014
 - #3 destroy handler throwing null error
 - #8 removed hard dependency on jquery and bootstrap
refactorthis added a commit that referenced this issue Jan 11, 2015
 - #3 destroy handler throwing null error
 - #8 removed hard dependency on jquery and bootstrap
refactorthis added a commit that referenced this issue Jan 11, 2015
 - #3 destroy handler throwing null error
 - #8 removed hard dependency on jquery and bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants