Replies: 5 comments
-
Hello @Mikilll94, thanks for the report. By design, authorization usually goes through per record, not just resource and action. So we are covering these use-cases by providing this feature. Also usually authorization servers are deployed together ideally in the same network so these requests are fast. For example, as a sidecar in kubernetes. We are supporting different types of access controls like RBAC, Scope based. As @omeraplak mentioned earlier here you can disable this feature for buttons individually. Since rendering 1000 rows in a page is a poor design and we can't possible handle %100 of the cases, we'll keep current approach here. However, if you have some suggestion/API Designs to handle your case, we can discuss and eventually implement it. |
Beta Was this translation helpful? Give feedback.
-
@BatuhanW |
Beta Was this translation helpful? Give feedback.
-
Just out of curiosity, how do you make 1000 requests to fetch 1000 records 🧐 and not just a single call that responds with the 1000 records? |
Beta Was this translation helpful? Give feedback.
-
@KOCNS1, AFAIK @Mikilll94 makes a single query which returns 1000 records, next 1000 requests are made by refine access control provider for each record. |
Beta Was this translation helpful? Give feedback.
-
I see, if you have some solution, API Design in mind, please share with us! We are happy to discuss and implement it. |
Beta Was this translation helpful? Give feedback.
-
Is your feature request related to a problem? Please describe.
I have noticed that
can
method from access control provider is executed for every row. This can lead to terrible performance when i.e. you need to make an http call to check permissions and have about 1000 rows. This will result in 1000 http calls.Steps To Reproduce
https://codesandbox.io/s/sharp-snowflake-yxc8q9?file=/src/App.tsx
Describe alternatives you've considered
No response
Additional context
No response
Describe the thing to improve
can
method from access control provider should be executed only once.Screenshot
Beta Was this translation helpful? Give feedback.
All reactions