Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error. #1801

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 15, 2017

Fix the attribute filter bug, needed a global replace.

@jkmarx jkmarx requested a review from scottx611x June 15, 2017 21:15
@jkmarx jkmarx self-assigned this Jun 15, 2017
@jkmarx jkmarx added this to the Release 1.5.7 milestone Jun 15, 2017
@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #1801 into jkmarx/data-set-2-simplify-popover will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@                          Coverage Diff                           @@
##           jkmarx/data-set-2-simplify-popover    #1801      +/-   ##
======================================================================
- Coverage                               40.41%   40.39%   -0.02%     
======================================================================
  Files                                     390      388       -2     
  Lines                                   25371    25339      -32     
  Branches                                 1271     1271              
======================================================================
- Hits                                    10254    10236      -18     
+ Misses                                  15117    15103      -14
Impacted Files Coverage Δ
refinery/ui/source/js/file-browser/module.js 100% <ø> (ø) ⬆️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 34.32% <100%> (-0.33%) ⬇️
...source/js/file-browser/directives/assay-filters.js 58.33% <66.66%> (ø) ⬆️
...rce/js/file-browser/services/reset-grid-service.js 91.66% <0%> (-8.34%) ⬇️
.../source/js/user-file-browser/services/user-file.js
...ui/source/js/user-file-browser/services/factory.js
...file-browser/ctrls/user-file-browser-files-ctrl.js 60% <0%> (+38.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6a20d...6ef0cdc. Read the comment docs.

* Fix bound bug by using the auto-resize ui-grid module.

* Remove unused dependency.

* Fix unit test.

* Jkmarx/data set 2 fix button hide (#1804)

* Show tool icon when selected.

* Fix hidden button bug.

* Add styles.
@jkmarx jkmarx merged commit 6061a0d into jkmarx/data-set-2-simplify-popover Jun 16, 2017
@jkmarx jkmarx deleted the jkmarx-data-set-2-attribute-filter-bug branch June 16, 2017 16:46
jkmarx added a commit that referenced this pull request Jun 16, 2017
* Remove unused method.

* Fix parsing error. (#1801)

* Fix parsing error.

* Fix bound bug by using the auto-resize ui-grid module. (#1802)

* Fix bound bug by using the auto-resize ui-grid module.

* Remove unused dependency.

* Fix unit test.

* Jkmarx/data set 2 fix button hide (#1804)

* Show tool icon when selected.

* Fix hidden button bug.

* Add styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants