Jkmarx/data set 2 fix button hide #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkmarx
commented
Jun 16, 2017
•
jkmarx
commented
- Fix button hiding behind launch pad
- Add icon to tool selection menu
Codecov Report
@@ Coverage Diff @@
## jkmarx-data-set-2-bound-bug #1804 +/- ##
============================================================
Coverage 40.39% 40.39%
============================================================
Files 388 388
Lines 25339 25339
Branches 1271 1271
============================================================
Hits 10236 10236
Misses 15103 15103Continue to review full report at Codecov.
|
jkmarx
added a commit
that referenced
this pull request
Jun 16, 2017
* Fix bound bug by using the auto-resize ui-grid module. * Remove unused dependency. * Fix unit test. * Jkmarx/data set 2 fix button hide (#1804) * Show tool icon when selected. * Fix hidden button bug. * Add styles.
jkmarx
added a commit
that referenced
this pull request
Jun 16, 2017
* Fix parsing error. * Fix bound bug by using the auto-resize ui-grid module. (#1802) * Fix bound bug by using the auto-resize ui-grid module. * Remove unused dependency. * Fix unit test. * Jkmarx/data set 2 fix button hide (#1804) * Show tool icon when selected. * Fix hidden button bug. * Add styles.
jkmarx
added a commit
that referenced
this pull request
Jun 16, 2017
* Remove unused method. * Fix parsing error. (#1801) * Fix parsing error. * Fix bound bug by using the auto-resize ui-grid module. (#1802) * Fix bound bug by using the auto-resize ui-grid module. * Remove unused dependency. * Fix unit test. * Jkmarx/data set 2 fix button hide (#1804) * Show tool icon when selected. * Fix hidden button bug. * Add styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.