Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - simplify popover in input group. #1800

Merged
merged 2 commits into from Jun 16, 2017

Conversation

jkmarx
Copy link
Member

@jkmarx jkmarx commented Jun 15, 2017

  • Simplify Popover by initializing variables in partial.

@jkmarx jkmarx self-assigned this Jun 15, 2017
@jkmarx jkmarx requested a review from mccalluc June 15, 2017 19:38
@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #1800 into develop will increase coverage by 0.91%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1800      +/-   ##
===========================================
+ Coverage    40.47%   41.39%   +0.91%     
===========================================
  Files          391      390       -1     
  Lines        25396    25828     +432     
  Branches      1271     1271              
===========================================
+ Hits         10280    10692     +412     
- Misses       15116    15136      +20
Impacted Files Coverage Δ
...tool-launch/directives/input-group-help-popover.js 100% <ø> (ø) ⬆️
...ui/source/js/tool-launch/ctrls/input-group-ctrl.js 88.23% <ø> (+1.19%) ⬆️
.../tool-launch/services/file-relationship-service.js 95.19% <ø> (-0.14%) ⬇️
refinery/ui/source/js/file-browser/module.js 100% <ø> (ø) ⬆️
refinery/ui/source/js/file-browser/ctrls/ctrl.js 34.32% <100%> (-0.33%) ⬇️
...source/js/file-browser/directives/assay-filters.js 58.33% <66.66%> (ø) ⬆️
...rce/js/file-browser/services/reset-grid-service.js 91.66% <0%> (-8.34%) ⬇️
...file-browser/ctrls/user-file-browser-files-ctrl.js 21.05% <0%> (-2.48%) ⬇️
refinery/tool_manager/utils.py 84.51% <0%> (-1.8%) ⬇️
refinery/tool_manager/models.py 92.81% <0%> (-0.1%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6911bd6...6061a0d. Read the comment docs.

@jkmarx jkmarx changed the title Remove unused method. Refactor - simplify popover in input group. Jun 16, 2017
* Fix parsing error.

* Fix bound bug by using the auto-resize ui-grid module. (#1802)

* Fix bound bug by using the auto-resize ui-grid module.

* Remove unused dependency.

* Fix unit test.

* Jkmarx/data set 2 fix button hide (#1804)

* Show tool icon when selected.

* Fix hidden button bug.

* Add styles.
@jkmarx jkmarx merged commit 4d447de into develop Jun 16, 2017
@jkmarx jkmarx deleted the jkmarx/data-set-2-simplify-popover branch June 16, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants