Mccalluc/preserve facets in fb2 #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(IGV test failure in push) |
…to prevent confusion
Codecov Report
@@ Coverage Diff @@
## develop #1981 +/- ##
===========================================
+ Coverage 43.72% 43.74% +0.02%
===========================================
Files 415 415
Lines 27381 27411 +30
Branches 1322 1322
===========================================
+ Hits 11971 11990 +19
- Misses 15410 15421 +11
Continue to review full report at Codecov.
|
scottx611x
changed the base branch from
develop
to
scottx611x/chucks_recent_prs
scottx611x
approved these changes
Aug 8, 2017
There was a problem hiding this comment.
No qualms about this, but I think its good motivation to address: #1882
8 tasks
scottx611x
added a commit
that referenced
this pull request
Aug 15, 2017
* I was sloppy earlier: We want to OR within, but AND across facets (#1983) * I was sloppy earlier: We want to OR within, but AND across facets * We want to reverse the normal order of operations: First OR within, then AND across * Hide zero facets (#1979) * Hide zero facets * Get tests to pass * Title is unnecessary (#1977) * Mccalluc/search facet labels (#1976) * Basic machinery * A litte style. Case-insensitive matching. * Mccalluc/preserve facets in fb2 (#1981) * Demonstrate that outside parameters can be inserted * Generate a query that looks like what the fb2 generates * There will also be a "filterQuery" for the download link, and I want to prevent confusion * Mccalluc/max height (#1975) * limit the height of the facet lists * Expand on hover? This is arguable * Add styles (#1985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it's best to take this as a proof of concept? The first problem is that filebrowser2 is still coming up blank for me on first load. filebrowser1 can't be targeted here, because it does not update the url when facets are applied. Is that's resolved, then there's the problem that the sets of facets just don't match between the pages. Do facets need to be added to one, or removed from the other?