More user friendly max-height #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## mccalluc/max-height #1985 +/- ##
====================================================
Coverage 43.68% 43.68%
====================================================
Files 415 415
Lines 27367 27367
Branches 1322 1322
====================================================
Hits 11956 11956
Misses 15411 15411Continue to review full report at Codecov.
|
scottx611x
pushed a commit
that referenced
this pull request
Aug 9, 2017
* limit the height of the facet lists * Expand on hover? This is arguable * Add styles (#1985)
scottx611x
added a commit
that referenced
this pull request
Aug 15, 2017
* I was sloppy earlier: We want to OR within, but AND across facets (#1983) * I was sloppy earlier: We want to OR within, but AND across facets * We want to reverse the normal order of operations: First OR within, then AND across * Hide zero facets (#1979) * Hide zero facets * Get tests to pass * Title is unnecessary (#1977) * Mccalluc/search facet labels (#1976) * Basic machinery * A litte style. Case-insensitive matching. * Mccalluc/preserve facets in fb2 (#1981) * Demonstrate that outside parameters can be inserted * Generate a query that looks like what the fb2 generates * There will also be a "filterQuery" for the download link, and I want to prevent confusion * Mccalluc/max height (#1975) * limit the height of the facet lists * Expand on hover? This is arguable * Add styles (#1985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
