Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply facets to csv download #2039

Closed
wants to merge 4 commits into from
Closed

apply facets to csv download #2039

wants to merge 4 commits into from

Conversation

mccalluc
Copy link
Member

Checkpoint: I think the solution is something like this, but I have not gotten csvFilterQuery to evaluate in the template

…ot gotten csvFilterQuery to evaluate in the template
@mccalluc mccalluc mentioned this pull request Aug 23, 2017
@codecov-io
Copy link

codecov-io commented Aug 23, 2017

Codecov Report

Merging #2039 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2039      +/-   ##
===========================================
+ Coverage    44.22%   44.22%   +<.01%     
===========================================
  Files          416      416              
  Lines        27711    27708       -3     
  Branches      1339     1339              
===========================================
  Hits         12254    12254              
+ Misses       15457    15454       -3
Impacted Files Coverage Δ
...file-browser/ctrls/user-file-browser-files-ctrl.js 12.9% <0%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ebee1...ccedaae. Read the comment docs.

@mccalluc
Copy link
Member Author

Close in favor of #2041

@mccalluc mccalluc closed this Aug 23, 2017
@mccalluc mccalluc deleted the mccalluc/filter-csv branch August 23, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants