Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/user files csv filtering #2041

Merged
merged 4 commits into from Aug 24, 2017

Conversation

mccalluc
Copy link
Member

I started off trying to give the download url nice simple params, but it's easier and more consistent to pass the solr-style ones through.

screen shot 2017-08-23 at 5 20 35 pm

Fix #1957

@codecov-io
Copy link

Codecov Report

Merging #2041 into develop will increase coverage by <.01%.
The diff coverage is 59.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2041      +/-   ##
===========================================
+ Coverage    44.22%   44.23%   +<.01%     
===========================================
  Files          416      417       +1     
  Lines        27706    27714       +8     
  Branches      1339     1339              
===========================================
+ Hits         12254    12260       +6     
- Misses       15452    15454       +2
Impacted Files Coverage Δ
.../source/js/user-file-browser/services/user-file.js 100% <ø> (+35%) ⬆️
...file-browser/ctrls/user-file-browser-files-ctrl.js 12.9% <0%> (-0.89%) ⬇️
.../js/user-file-browser/services/user-file-params.js 65% <65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf5019...4276fbc. Read the comment docs.

@scottx611x scottx611x merged commit 0139c1e into develop Aug 24, 2017
@scottx611x scottx611x deleted the mccalluc/user-files-csv-filtering branch August 24, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants