Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/merge facets #2073

Merged
merged 9 commits into from Sep 5, 2017
Merged

Mccalluc/merge facets #2073

merged 9 commits into from Sep 5, 2017

Conversation

mccalluc
Copy link
Member

@mccalluc mccalluc commented Sep 4, 2017

Fix #2069. I do not have an exact reproducer on my screen, but I believe I understand the mechanism, and this PR addresses it.

@codecov-io
Copy link

Codecov Report

Merging #2073 into develop will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2073      +/-   ##
==========================================
+ Coverage    44.28%   44.4%   +0.12%     
==========================================
  Files          417     417              
  Lines        27771   27855      +84     
  Branches      1346    1353       +7     
==========================================
+ Hits         12298   12369      +71     
- Misses       15473   15486      +13
Impacted Files Coverage Δ
...ui/source/js/user-file-browser/services/factory.js 91.04% <100%> (+53.54%) ⬆️
refinery/user_files_manager/views.py 87.27% <0%> (-10.29%) ⬇️
...le-browser/ctrls/user-file-browser-filters-ctrl.js 8.21% <0%> (-0.71%) ⬇️
...file-browser/ctrls/user-file-browser-files-ctrl.js 10.63% <0%> (-0.48%) ⬇️
refinery/user_files_manager/tests.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dd3c6...1119e60. Read the comment docs.

@mccalluc mccalluc merged commit 5acc9c2 into develop Sep 5, 2017
@mccalluc mccalluc deleted the mccalluc/merge-facets branch September 5, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants