-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove filetypes fq #2288
Remove filetypes fq #2288
Conversation
3 fails, just because solr query doesn't match:
I'll fix those. |
One of two builds fails:
Haven't seen this before. Just try restarting... |
Codecov Report
@@ Coverage Diff @@
## develop #2288 +/- ##
===========================================
+ Coverage 50.37% 51.89% +1.51%
===========================================
Files 377 377
Lines 26916 27765 +849
Branches 1241 1241
===========================================
+ Hits 13560 14409 +849
Misses 13356 13356
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the consensus on this still that we weren't sure as to what the 0 Facet Value behavior in the Filebrowsers should be so theres no clear path to proceed?
I think that's where we left it... There are a couple ideas out there:
but also:
|
Thinking a little more: The simplest thing is probably just not to index these documents in the first place... but still store the files, in case we want to reindex and make them visible? |
* Skip indexing for some files * Apply changes from #2288: Bad docs will be excluded from index rather than excluded by query. * 2nd thought, not config, but make it a Node class constant
Fix #2106?