New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip indexing for some files #2330
Skip indexing for some files #2330
Conversation
… than excluded by query.
Codecov Report
@@ Coverage Diff @@
## develop #2330 +/- ##
===========================================
- Coverage 51.31% 50.33% -0.98%
===========================================
Files 389 381 -8
Lines 26981 26433 -548
Branches 1246 1240 -6
===========================================
- Hits 13844 13306 -538
+ Misses 13137 13127 -10
Continue to review full report at Codecov.
|
On second thought, perhaps not a config, but class constant. I think this is all that is needed now? Do not merge for 1.6.1 |
@@ -71,6 +72,8 @@ def _assay_data(self, object): | |||
# https://groups.google.com/forum/?fromgroups#!topic/django-haystack/g39QjTkN-Yg | |||
# http://stackoverflow.com/questions/7399871/django-haystack-sort-results-by-title | |||
def prepare(self, object): | |||
if object.type not in Node.INDEXED_FILES: | |||
raise SkipDocument() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can SkipDocument
accept a message? Could be useful for debugging.
@ngehlenborg : Can you schedule time to give input on this, or delegate someone who can make a call? There are several fairly simple changes we could make that would fix the behavior, but we're not sure which is best. |
@scottx611x : Talked with Nils: Coming out of that, the idea was to show all documents, but for all the doc types we don't recognize, change the type, but also add a new field to the object so we could theoretically export the original. With a little distance, that feels too complicated, and too fragile. How would you feel about merging this original PR, and putting the rest on the back burner? |
@mccalluc I agree on the fragility of: Let me look over this PR again first and I'll give a better opinion |
@mccalluc I'd be okay with merging this as long as we move our future intentions into a new issue |
Fix #2106? Does this seem like a reasonable approach? I still want to: