-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackdna/update fabfile #2648
Hackdna/update fabfile #2648
Conversation
fabfile.py
Outdated
run("git checkout {branch}".format(**env)) | ||
# update current branch in Vagrant VM, otherwise checkout custom branch | ||
if env.project_user != 'vagrant': | ||
run("git checkout {branch}".format(**env)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment confused me a little bit, because it reads like an if-then, but with the sense reversed from the code... Maybe a comment after instead, something like
# ... but if using Vagrant, current branch is fine.
Not a big deal either way. Thanks!
Codecov Report
@@ Coverage Diff @@
## develop #2648 +/- ##
==========================================
- Coverage 56.68% 55.1% -1.59%
==========================================
Files 400 400
Lines 26881 25231 -1650
Branches 1241 1241
==========================================
- Hits 15238 13903 -1335
+ Misses 11643 11328 -315
Continue to review full report at Codecov.
|
Remove a redundant checkout