Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackdna/update fabfile #2648

Merged
merged 4 commits into from
Mar 9, 2018
Merged

Hackdna/update fabfile #2648

merged 4 commits into from
Mar 9, 2018

Conversation

hackdna
Copy link
Member

@hackdna hackdna commented Mar 5, 2018

Remove a redundant checkout

fabfile.py Outdated
run("git checkout {branch}".format(**env))
# update current branch in Vagrant VM, otherwise checkout custom branch
if env.project_user != 'vagrant':
run("git checkout {branch}".format(**env))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment confused me a little bit, because it reads like an if-then, but with the sense reversed from the code... Maybe a comment after instead, something like

# ... but if using Vagrant, current branch is fine.

Not a big deal either way. Thanks!

@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #2648 into develop will decrease coverage by 1.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2648      +/-   ##
==========================================
- Coverage    56.68%   55.1%   -1.59%     
==========================================
  Files          400     400              
  Lines        26881   25231    -1650     
  Branches      1241    1241              
==========================================
- Hits         15238   13903    -1335     
+ Misses       11643   11328     -315
Impacted Files Coverage Δ
refinery/factory_boy/utils.py 86.95% <0%> (-4.35%) ⬇️
refinery/data_set_manager/models.py 81.12% <0%> (-3.71%) ⬇️
refinery/core/models.py 69.5% <0%> (-3.51%) ⬇️
refinery/data_set_manager/views.py 45.29% <0%> (-2.68%) ⬇️
refinery/core/views.py 27.53% <0%> (-2%) ⬇️
refinery/file_store/models.py 69.69% <0%> (-1.74%) ⬇️
refinery/core/api.py 40.98% <0%> (-0.28%) ⬇️
refinery/data_set_manager/tests.py 99.75% <0%> (-0.01%) ⬇️
refinery/factory_boy/django_model_factories.py 100% <0%> (ø) ⬆️
refinery/core/tests.py 99.5% <0%> (+0.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ce3b9...c9abc3f. Read the comment docs.

@hackdna hackdna merged commit c3778eb into develop Mar 9, 2018
@hackdna hackdna deleted the hackdna/update-fabfile branch March 9, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants