New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to chrome headless instead of phantomjs #3391

Closed
aiomaster opened this Issue Aug 20, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@aiomaster
Contributor

aiomaster commented Aug 20, 2018

I noticed a lot of random fails in the feature tests (on travis they were just executed up to 3 times until they hopefully work). Maybe you should consider to use selenium with a real browser like chromium. phantomjs is abondoned and has a very old rendering engine, so it would really be cool to update the test suite to chrome headless and maybe get rid of some of the random failing tests.

@bricesanchez

This comment has been minimized.

Member

bricesanchez commented Aug 22, 2018

Hi @aiomaster,

You're right, we should use another solution, could you provide us a PR ?

:)

@bricesanchez bricesanchez added this to the 5.0 milestone Aug 22, 2018

bricesanchez added a commit that referenced this issue Aug 23, 2018

@bricesanchez

This comment has been minimized.

Member

bricesanchez commented Aug 23, 2018

@aiomaster I've created a PR for this feature

@aiomaster

This comment has been minimized.

Contributor

aiomaster commented Aug 24, 2018

Impressive, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment