Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to chrome headless instead of phantomjs #3391

Closed
aiomaster opened this issue Aug 20, 2018 · 3 comments · Fixed by #3394
Closed

Switch to chrome headless instead of phantomjs #3391

aiomaster opened this issue Aug 20, 2018 · 3 comments · Fixed by #3394
Milestone

Comments

@aiomaster
Copy link
Contributor

I noticed a lot of random fails in the feature tests (on travis they were just executed up to 3 times until they hopefully work). Maybe you should consider to use selenium with a real browser like chromium. phantomjs is abondoned and has a very old rendering engine, so it would really be cool to update the test suite to chrome headless and maybe get rid of some of the random failing tests.

@bricesanchez
Copy link
Member

Hi @aiomaster,

You're right, we should use another solution, could you provide us a PR ?

:)

@bricesanchez
Copy link
Member

@aiomaster I've created a PR for this feature

@aiomaster
Copy link
Contributor Author

Impressive, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants