Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refinery_icon_tag helper no longer working in Refinery 4 #3398

Open
dianaq12 opened this issue Aug 27, 2018 · 0 comments
Open

refinery_icon_tag helper no longer working in Refinery 4 #3398

dianaq12 opened this issue Aug 27, 2018 · 0 comments

Comments

@dianaq12
Copy link

dianaq12 commented Aug 27, 2018

I just upgraded to Refinery 4. I'm also using the refinerycms-inquiries gem. That gem is still using refinery_icon_tag helper to render the action icons in the admin. After I upgraded none of the action icon images where displayed any more. I tracked the problem down to core/app/helpers/refinery/tag_helper.rb:18. If I remove skip_pipeline: true then the images are displayed correctly. I see that refinery_icon_tag is going to get deprecated in favor of action_icon. So I went ahead and created a PR with that change in the refinery-inquiries repo but thought I would bring it up here in case there are other plugins that might have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant