Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We want to make sure that we CI Ruby 2.2 #2773

Merged
merged 1 commit into from
Dec 1, 2014
Merged

Conversation

parndt
Copy link
Member

@parndt parndt commented Nov 28, 2014

No description provided.

@simi
Copy link
Member

simi commented Nov 28, 2014

allow_failure should be ok for now IMHO

@parndt
Copy link
Member Author

parndt commented Nov 28, 2014

It shouldn't fail, it passes for me locally. I guess Travis doesn't have preview2 yet.

@simi
Copy link
Member

simi commented Nov 28, 2014

We should not rely on unreleased ruby on CI.

@parndt
Copy link
Member Author

parndt commented Nov 28, 2014

Well I don't mind if it moves to an allow failure block

@parndt
Copy link
Member Author

parndt commented Dec 1, 2014

Of course the build actually passes completely.

@parndt
Copy link
Member Author

parndt commented Dec 1, 2014

Ruby 2.2 is out in ~24 days, it'd be nice to eliminate any bugs early.

@robyurkowski
Copy link
Contributor

As @parndt and I discussed today, we're going to add this without allow_failure. We want compat for 2.2 going forward, and it will take some effort to break compat given that we're already passing.

robyurkowski added a commit that referenced this pull request Dec 1, 2014
We want to make sure that we CI Ruby 2.2
@robyurkowski robyurkowski merged commit 65176fe into master Dec 1, 2014
@robyurkowski robyurkowski deleted the ruby-2-2-ci branch December 1, 2014 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants