dialect overflow e.g. zh-TW

[arthurtalkgoal]

No description provided.

[simi]

✂️

[simi]

Hello @arthurtalkgoal. Can you please provide describing spec for this helper?

[simi]

Also can you merge master in or rebase?

[arthurtalkgoal]

Sure! just found that mine isn't merged

[simi]

If I understand well, this is separating country from locale code. If that's correct, I thinkt it will be good to rename truncate_locale method to locale_country or similar. Does it make sense?

[simi]

Any reason to not use locale_country here also?

[arthurtalkgoal]

Same as below reply. I applied full text for alt. And I am ok to apply locale_country anywhere if applicable.

[simi]

I've added few comments. Sorry for being so pedantic.

[simi]

Please can you strip those whitespace changes @arthurtalkgoal? I'll merge after.

[parndt]

We can always use split, in conjunction with [-1]

def locale_country(locale)
  locale.upcase.to_s.split('-')[-1]
end

irb(main):001:0> 'en-US'.split('-')[-1]
=> "US"
irb(main):002:0> 'en'.split('-')[-1]
=> "en"

[simi]

actually it should be

locale.to_s.upcase.split('-').last

[parndt]

@simi wins

flawless victory

[arthurtalkgoal]

locale.to_s.upcase.split('-').last is a smart ways to save codes!

[simi]

✂️ ?

[parndt]

Seems like a good option to configure your editor to strip out trailing whitespace. In sublime text, you can do this with this preference:

"trim_trailing_white_space_on_save": true

In fact here's my entire preferences file:

{
    "bold_folder_labels": true,
    "color_scheme": "Packages/Theme - Flatland/Flatland.tmtheme",
    "draw_white_space": "selection",
    "ensure_newline_at_eof_on_save": true,
    "file_exclude_patterns":
    [
        ".DS_Store",
        ".travis_status~"
    ],
    "folder_exclude_patterns":
    [
        ".git",
        ".rbx",
        "tmp",
        "log",
        "doc",
        ".bundle",
        "coverage",
        ".vagrant"
    ],
    "font_face": "Monaco",
    "font_options":
    [
        "subpixel_antialias"
    ],
    "font_size": 15.0,
    "highlight_line": true,
    "ignored_packages":
    [
        "Vintage"
    ],
    "rulers":
    [
        80,
        120
    ],
    "save_on_focus_lost": true,
    "scroll_past_end": true,
    "tab_completion": true,
    "tab_size": 2,
    "theme": "Flatland.sublime-theme",
    "translate_tabs_to_spaces": true,
    "trim_trailing_white_space_on_save": true
}

[parndt]

Thanks for your work on this; would really appreciate if it were squashed down to one commit. Let me know if this is a problem for you and I can do it instead.

Is this going to be a problem that zh-TW will become just TW? (As that is a country, and not a locale)

[simi]

🎺 squash'n'merge 🌐

[arthurtalkgoal]

Hi parndt,

I use vim or most of the time Windows Notepad++, I am not sure how the trailing_white_space created.

I will check it next time. Would you mind combine it into a commit for me?

re zh-TW to TW:
The locale code is in fact zh-TW, it won't work if converted to "TW" in codes/locale setting.

But for display purpose, we understand "TW" stands for Taiwan and Traditional Chinese; "CN" for simiplied chinese. and HK for Hong kong chinese etc.

[simi]

@arthurtalkgoal should I squash it for you?

[arthurtalkgoal]

@simi, yes, please.