Removed spring from Gemfile, moved poltergeist and quiet_assets to groups #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oups. Spring still works just fine for me if I put it in .gemfile which is a file that we have for installing gems according to each developer's preference. If I completely uninstall Spring from my system then it still works to invoke every command that asks for Spring due to Spring rescuring from LoadError. If I then place Spring back in .gemfile it will figure out that it is now present and will load, speeding up subsequent invocations.
| gem 'spring' | ||
| gem 'spring-commands-rspec' | ||
| gem 'poltergeist' | ||
| gem 'quiet_assets', group: :development |
There was a problem hiding this comment.
The test group is a block so I think it would make sense for the development group to be a block even though there's only one item in it. Either way I think it would be better to have the development gems separate from the production gems, so move this to between the database config conditions and the test group.
There was a problem hiding this comment.
Technically there are no production gems, given this is never run in production ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring still works just fine for me if I put it in
.gemfilewhichis a file that we have for installing gems according to each developer's
preference. If I completely uninstall Spring from my system then it
still works to invoke every command that asks for Spring due to
Spring rescuring from
LoadError.If I then place Spring back in
.gemfileit will figure out that itis now present and will load, speeding up subsequent invocations.