Bye Selenium! #2806
Bye Selenium! #2806
Conversation
| @@ -6,7 +6,7 @@ gem 'refinerycms-i18n', git: 'https://github.com/refinery/refinerycms-i18n', bra | |||
| gem 'quiet_assets' | |||
| gem 'spring' | |||
| gem 'spring-commands-rspec' | |||
| gem 'poltergeist' | |||
| gem 'poltergeist', github: 'teampoltergeist/poltergeist' | |||
There was a problem hiding this comment.
Is this because of teampoltergeist/poltergeist@2d23867 ?
There was a problem hiding this comment.
exactly
but this PR can be around till release
|
@simi I rebased this, which is going to display like I cherry picked your commit. If you'd like to rebase it yourself I think that would undo that, but if you're otherwise happy then we'll see how CI is. |
|
One test is failing random (was with selenium also). But I can solve it with my plan later. |
|
Yep, if it was failing before, I don't see the point in delaying this over it 😄 |
|
This removes selenium from refinery core. So probably another repositories will need a little love. Let me inspect. |
|
Yes, for example |
|
@simi most extensions use CI so we'll find out which ones will fail as they fail for the most part. I can tell you right now the blog won't work without the gemspec change I did in parndt/refinerycms-wymeditor@8a16114 |
|
Or we can keep is a dependency for now. But just don't use it. |
|
Now's the best time to remove it. |
TODO