Redirect to root_path unless admin_root_path

[developer88]

If just a user tries to navigate to admin#index it receives 'Cannot redirect to nil!'. I propose to redirect to root path.

[simi]

Can you describe me usecase? I don't understand this change.

[parndt]

At the very least, we need a test demonstrating the use case that fails with the old code too.

[developer88]

@parndt I will add some specs a bit later
@simi What happened if user that is not an admin navigate to admin_root_path? In my case this method just returns nil and than i receives 500 error (because redirect_to nil).

So. i have added a refinery.root_path to redirect user back to root page of CMS

[parndt]

I have a hesitation based around the implementation. Currently the method is called refinery_admin_root_path but it is, in fact, returning refinery.root_path under the case where they're not logged in. This is kind of confusing!

Furthermore, I'm confused as to why this method is even being accessed when the user is not logged in, as this is an admin method. Perhaps we have another design error (i.e. we're not restricting early enough) that this would simply be covering up?

[parndt]

I believe that if we are to patch this, @developer88, it should be here: https://github.com/refinery/refinerycms/blob/master/core/app/controllers/refinery/admin/core_controller.rb#L5

module Refinery
  module Admin
    class CoreController < ::Refinery::AdminController
      def index
        redirect_to(refinery_admin_root_path || refinery_root_path)
      end