Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refinerycms-i18n to gemfile template for engines #2839

Closed
wants to merge 2 commits into from

Conversation

CJYate
Copy link
Contributor

@CJYate CJYate commented Jan 19, 2015

To fix issue #2835

This adds the dependency to an engine's Gemfile.

Manually tested with a dummy app.

@simi
Copy link
Member

simi commented Jan 19, 2015

@parndt should be this locked to stable release once new stable release will be out?

Also @CJBrew can you use new hash syntax?

@CJYate
Copy link
Contributor Author

CJYate commented Jan 19, 2015

Tweaked the hash syntax. Thanks.

@parndt
Copy link
Member

parndt commented Jan 19, 2015

@simi yes absolutely, though currently it breaks out of the box so this seems good. @CJBrew Do we need this for forms as well?

@CJYate
Copy link
Contributor Author

CJYate commented Jan 19, 2015

@parndt yes, I think it'll be needed on Forms.

But I've not attempted to merge the work I did on forms generator up to Edge, so there's currently not even a Gemfile to add it to.

@parndt
Copy link
Member

parndt commented Jan 21, 2015

No longer required because of #2846

@parndt parndt closed this Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants