Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 4.2 support #2889

Merged
merged 9 commits into from
Feb 19, 2015
Merged

Rails 4.2 support #2889

merged 9 commits into from
Feb 19, 2015

Conversation

simi
Copy link
Member

@simi simi commented Feb 15, 2015

TODO

  • use routing-filter gem instead of custom fork
  • check friendly id errors on CI

@simi simi changed the title Rails 4 2 support Rails 4.2 support Feb 15, 2015
@simi simi mentioned this pull request Feb 15, 2015
Closed
@simi
Copy link
Member Author

simi commented Feb 15, 2015

The failing test (twice) is caused because this behavior:

on master:

Globalize.locale
=> :en
Refinery::Page.last.slug
=> "новости"

in this PR:

Globalize.locale
=> :en
Refinery::Page.last.slug
=> nil

@simi
Copy link
Member Author

simi commented Feb 18, 2015

Do we need to wait for Globalize 5.1.0 here?

simi added a commit that referenced this pull request Feb 19, 2015
@simi
Merge pull request #2889 from refinery/rails-4-2
6d008dc 
Rails 4.2 support
@simi simi merged commit 6d008dc into master Feb 19, 2015
@simi
Copy link
Member Author

simi commented Feb 19, 2015

Rails everywhere

giphy 3

@parndt parndt deleted the rails-4-2 branch February 19, 2015 03:26
@bricesanchez
Copy link
Member

🎊 🎉

@bricesanchez bricesanchez mentioned this pull request Feb 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simi @bricesanchez @parndt