Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spruced up the 'ol thing. #2898

Merged
merged 4 commits into from
Feb 24, 2015
Merged

Spruced up the 'ol thing. #2898

merged 4 commits into from
Feb 24, 2015

Conversation

parndt
Copy link
Member

@parndt parndt commented Feb 18, 2015

Not ready yet..

Currently:

THE SPRUCE GOOSE?!?

This is loosely based on this UI design:

ui_15

Help required:

Need to figure out a way to extend the white background to the bottom of the browser without showing a scroll bar or setting a background image on the body etc. Anyone know how that works best in 2015?

@parndt
Copy link
Member Author

parndt commented Feb 18, 2015

Apparently height: 100vh might be our friend - thanks @lengarvey

Though, maybe not perfect on all browsers like mobile.

@roonie
Copy link

roonie commented Feb 24, 2015

Setting the min-height to 100% can do the trick. For it to work, the parents has to have a height of 100%. Using a min-height has the pro of extending when the content grows.

@roonie
Copy link

roonie commented Feb 24, 2015

Here is a quick preview how to do it (sass)

html
  height: 100%
body
  height: 100%
  .thing_wrapper
    height: 100%
    padding: 52px 0 0
    position: relative
    box-sizing: padding-box
    .white_thing
      min-height: 100%

@parndt
Copy link
Member Author

parndt commented Feb 24, 2015

@roonie nice! Thank you for the example code! ❤️

@parndt parndt merged commit fa3f0b6 into master Feb 24, 2015
@parndt parndt deleted the spruce-goose branch February 24, 2015 21:34
@parndt
Copy link
Member Author

parndt commented Feb 24, 2015

Thanks, @roonie and @johanb for the push over the edge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants