Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use engine routes in specs. #2946

Merged
merged 2 commits into from
Apr 9, 2015
Merged

Use engine routes in specs. #2946

merged 2 commits into from
Apr 9, 2015

Conversation

simi
Copy link
Member

@simi simi commented Apr 9, 2015

fixes #2937

ping @parndt, @CJBrew

[ryba@retro  refinerycms (use-engine-routes-in-specs)]❤ bin/rspec core/spec/controllers/refinery/admin/dummy_controller_spec.rb pages/spec --order standard
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
..........................................................................DEPRECATION WARNING: You are calling a `*_path` helper with the `only_path` option explicitly set to `true`. This option will stop working on path helpers in Rails 5. Simply remove the `only_path: true` argument from your call as it is redundant when applied to a path helper. (called from block (3 levels) in <module:Refinery> at /opt/ryba/refinerycms/pages/spec/features/refinery/pages_spec.rb:231)
...................................................................................................................................................................

Finished in 1 minute 26.79 seconds (files took 0.73418 seconds to load)
237 examples, 0 failures

parndt added a commit that referenced this pull request Apr 9, 2015
@parndt parndt merged commit 04cc80f into master Apr 9, 2015
@parndt parndt deleted the use-engine-routes-in-specs branch April 9, 2015 19:22
@CJYate
Copy link
Contributor

CJYate commented Apr 10, 2015

Hi Josef,

Thanks for the fix. Not saying it's wrong, but I don't understand it 100%.
Especially the bit where you build the routes

Not by a computer for a few days, but could you briefly explain this for my
benefit?

Does this change basically achieve the same thing I did in nicer, up to
date code style with reference to the Refinery Engine? Is this what I
missed when I did it (using the examples on the Rspec documentation as
inspiration)?

Cheers, Chris

@simi
Copy link
Member Author

simi commented Apr 10, 2015

Sorry, but I'm out of time. Check https://github.com/refinery/refinerycms/pull/2928/files#r28077110, that declaration belongs to engine code and you're changing testing code only. Actually it's future goal to have isolated "Frontend" and "Backend" namespaces.

ping me on the gitter for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running pages spec after core/spec/controllers/refinery/admin/dummy_controller_spec.rb fails
3 participants