Generator specs clean up after themselves. #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having issues running the generator specs because I got permission denied errors for the tmpdir that was being used in the spec for engine_generator_multiple_resources. I then noticed that the other specs use a relative path inside the core/ directory for the temporary directory. I've switched the spec to do this and also added an after which cleans up after the test ensuring no extra files or folders are left lying around on the file system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues running the generator specs because I got permission
denied errors for the tmpdir that was being used in the spec for
engine_generator_multiple_resources.
I then noticed that the other specs use a relative path inside the core/
directory for the temporary directory.
I've switched the spec to do this and also added an after which cleans
up after the test ensuring no extra files or folders are left lying
around on the file system.