Feature image crop #3380
Merged
Feature image crop #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's pretty exciting @bricesanchez |
parndt
approved these changes
Jul 13, 2018
|
keen for @anitagraham to take a look |
parndt
reviewed
Jul 15, 2018
|
|
||
| <% content_for :stylesheets do %> | ||
| <%= stylesheet_link_tag('refinery/plugins/cropper') %> | ||
| <% end %> |
There was a problem hiding this comment.
if it's just one, you can normally in-line it:
<% content_for :stylesheets, stylesheet_link_tag('refinery/plugins/cropper') -%>
bricesanchez
force-pushed
the
feature/image-crop
branch
from
23bac85
to
5575ad5
Compare
|
@parndt I've made some change to support a message if there is no crop. Could you review it please? |
parndt
reviewed
Jul 18, 2018
| </ul> | ||
| <% if @image.crops.present? %> | ||
| <ul id="crop-list" class="clearfix"> | ||
| <% @image.crops.each do |crop| %> |
There was a problem hiding this comment.
does <%= render @image.crops %> work here?
Or
<%= render partial: 'crop', collection: @image.crops
I think Rails handles this with syntax like one of the above, provided it can find the partial.
bricesanchez
force-pushed
the
feature/image-crop
branch
from
8f1bc27
to
f7b7f28
Compare
|
Hi @anitagraham, do you have the time to check this PR? |
bricesanchez
force-pushed
the
feature/image-crop
branch
from
398b6ae
to
4898c25
Compare
|
With this latest commit, this feature works well on all major browsers including Edge :) |
bricesanchez
force-pushed
the
feature/image-crop
branch
from
2f54053
to
4898c25
Compare
* Use Cropper.js lib (https://github.com/fengyuanchen/cropperjs) * No dependency to jQuery * Add Ability to write multiple crops in Admin Image Edit form * Use pre-defined or custom crop ratios * Add Ability to use crop in WYSIWYG editors and in Image insert dialog
Also don't import cropper css in main refinery
bricesanchez
force-pushed
the
feature/image-crop
branch
from
4898c25
to
fdfab9f
Compare
|
Could we merge it @parndt? |
|
Yep 😄 |
|
This looks great. I am sorry I wasn't around to help review it - about to use it now, instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests added for this feature, sorry :(