Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page tree cache refresh on sub page changes #3390

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

aiomaster
Copy link
Contributor

@aiomaster aiomaster commented Aug 20, 2018

Hi,
it took me some hours to find and fix a problem that came in with admin page index collection caching (see a1b6e8a).
Problem was, that the page tree showed old pages if we changed a page title on a sub child of one of the children of a page.
The collection caching just checked the children of a page, but not if a child (or child of a child ...) was changed. So we ended with a wrong page tree.
I wrote a test and fixed the problem by including the descendants of a page into the caching decision.
Cheers!

@aiomaster
Copy link
Contributor Author

I really don't know why the travis tests with mysql fail. I can not reproduce it on my local machine. Strange!

@aiomaster
Copy link
Contributor Author

aiomaster commented Aug 20, 2018

Funny, it was a caching problem :)
added a Rails.cache.clear seems to fix it.

@bricesanchez
Copy link
Member

@aiomaster thanks you so much, i did not test this feature on a sub child!

@parndt parndt merged commit 42282ca into refinery:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants