Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now validate resources mime_types #3403

Merged
merged 7 commits into from Sep 20, 2018
Merged

Now validate resources mime_types #3403

merged 7 commits into from Sep 20, 2018

Conversation

bricesanchez
Copy link
Member

@bricesanchez bricesanchez commented Sep 19, 2018 •
edited by parndt

  • Accept only file types we allow
  • Add ability to change the default configuration.
  • Run and fix offenses with Rubocop

@bricesanchez
Now validate resources mime_types
ea600ff 
* Accept only file types we allow
* Add ability to change de default configuration.
* Run and fix offenses with Rubocop
@bricesanchez bricesanchez added this to the 5.0 milestone Sep 19, 2018
@parndt
Copy link
Member

parndt commented Sep 19, 2018

I routinely upload all kinds of file types (including images) as resources, yet this defaults Refinery to only accepting PDFs. I'm not sure I'm happy with it being that restrictive..

@bricesanchez
Copy link
Member Author

which files types would you like as default?, i don't want to allow files that can be executed without permission.

@parndt
Copy link
Member

parndt commented Sep 19, 2018

that's fair, however I think we should support all of the standard image formats that images does, text files, etc as well

@bricesanchez bricesanchez requested review from parndt and removed request for parndt September 19, 2018 13:22
@bricesanchez bricesanchez merged commit 0d92490 into master Sep 20, 2018
@bricesanchez bricesanchez deleted the feature/resource-whitelist-mime-types branch September 20, 2018 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parndt parndt parndt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bricesanchez @parndt