[Admin UI] tweak litter style and use the more beautiful rich editor. #3418
Conversation
lanzhiheng
changed the title
|
@bricesanchez I think we need a more beautiful rich editor for New Admin UI. |
There was a problem hiding this comment.
@lanzhiheng I agree we need a more beautiful rich editor but there are some consideration to take :
- The WYSIWYG should be extracted from the core of Refinery like we do with
refinerycms-wymeditor - It should support at least the same feature as Wymeditor (including the way to reference images, resources, pages)
- It should be free to use : Sadly, Froala is not free https://github.com/froala/wysiwyg-rails#license
- It should not require jQuery
I'm sorry but at this time i can't accept this PR with a new WYSIWYG
|
@bricesanchez Thank you for your comments. I will try to search the suitable editor for it. |
lanzhiheng
force-pushed
the
change-default-rich-editor
branch
from
08951ee
to
5024899
Compare
lanzhiheng
changed the title
lanzhiheng
force-pushed
the
change-default-rich-editor
branch
from
5024899
to
a80806f
Compare
lanzhiheng
changed the title
|
@bricesanchez I have change the editor like below. I need to add an extra api for image upload I am not sure if you can accept it. please give me some feedback.
I just include very basic feature for ckeditor, if you need powerful function, I can rebuild a new package with some plugin. |
| @@ -10,4 +10,6 @@ | |||
| *= require jquery/jquery.browser | |||
| *= require admin | |||
| *= require refinery/core | |||
| *= require ckeditor | |||
There was a problem hiding this comment.
where is this dependency defined?
|
@bricesanchez what do you think of the above? I think the UI looks nice, but probably it should be an extension. |
|
@parndt CKeditor have the licence issue. So I create a special engine base by trix which have the MIT licence https://github.com/lanzhiheng/refinerycms-trix . It is very easy to extend. But the problem is that the editor is too poor basecamp/trix#587 . |
|
Will all this be achieved in Rails 6 by https://github.com/rails/rails/tree/master/actiontext ? |
|
@parndt yes it should be an extension, i think we could close this PR. |
No description provided.