Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection caching page links #3459

Merged
merged 1 commit into from Nov 27, 2019
Merged

Conversation

bricesanchez
Copy link
Member

Change proposed by @evenreven

Copy link
Member

@parndt parndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, as long as the cache gets busted appropriately (i.e. when we expect it to). It makes sense.

@bricesanchez bricesanchez merged commit d7a92b2 into master Nov 27, 2019
@bricesanchez bricesanchez deleted the pages_dialogs_cache_master branch November 27, 2019 19:55
@evenreven
Copy link
Contributor

Thank you for reviewing and merging this @bricesanchez and @parndt ! I have around 700 pages in my project, most of them bilingual (if that matters in this case). I just deployed this change to production now, and clicking insert link went from 12 seconds down to 0.13 seconds!

So hopefully this helps other users too. I have created pages and tried insert links again, and I see no issues with stale cache, but I'll keep my eyes peeled in the days and weeks to come and will report back if I come across anything. But using collection caching on a standard model like this should be safe.

@bricesanchez
Copy link
Member Author

Thanks for your help @evenreven!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants